Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: familiars upon death #3231

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

mdbeng
Copy link
Contributor

@mdbeng mdbeng commented Jan 9, 2025

This will not affect any behavior besides what is mentioned in the description

Description

This will fix the issue where if a familiar die and the player relogs he will summon his familiar with the remaining time, so the summon is infinite until time runs out. This will fix that and have a normal behavior

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested with promotion / no promotion
  • Tested with exit / suicide / pvp death / monsters death
  • Tested all combinations trying to break it again, and its working as expected.

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

This will fix the issue where if a familiar die and the player relogs he will summon his familiar with the remaining time, so the summon is infinite until time runs out. This will fix that and have a normal behavior
Copy link

sonarqubecloud bot commented Jan 9, 2025

@majestyotbr majestyotbr changed the title Familiars upon death fixed. fix: familiars upon death Jan 10, 2025
@majestyotbr majestyotbr merged commit 8434152 into opentibiabr:main Jan 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants