Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty fluid containers load #3243

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

phacUFPE
Copy link
Contributor

Description

Fixes the empty containers load that were being loaded as water filled.

Behaviour

Actual

Loads fluid containers with water filled instead of empty.

Expected

Loads fluid containers empty correctly.

Fixes #2210

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check an fluid container that should be loaded as empty in the map, it should be empty.

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@phacUFPE phacUFPE force-pushed the phacUFPE/fix_empty_fluid_containers branch from 881e0a2 to 4f72085 Compare January 11, 2025 22:02
@majestyotbr majestyotbr merged commit a4bc455 into main Jan 12, 2025
33 checks passed
@majestyotbr majestyotbr deleted the phacUFPE/fix_empty_fluid_containers branch January 12, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Filled Items
3 participants