fix: correct fee validation logic in market offer creation #3250
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the market offer creation process where the player was incorrectly prevented from posting items for sale due to a faulty calculation of the required funds. The validation now ensures the player has enough money to pay only the market fee, rather than the total price of the items plus the fee.
Behaviour
Actual
When attempting to create a market sell offer, the player is blocked if their total money (hand + bank balance) is less than the total price of the items plus the fee.
Do this and that doesn't happens
Expected
The player should only need enough money to cover the fee for creating the market offer.
Fixes #issuenumber
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Test Scenarios:
Posting an item where the player has enough money for the fee only.
Attempting to post an item without sufficient funds for the fee.
Test Configuration:
Checklist