Add validation for generated json metafiles

[kislerdm]

Resolves #152

What changed

• Added the program which validates json metadata files for modules and providers by performing a set of checks. It reports all found errors to stderr and terminates with the exit code 1 if the file is invalid, otherwise, it terminates with the exit code 0 without any messages.

Why do we need it

• To validate correctness of updated json metafiles

Examples

Provider

Module

[kislerdm]

Hey @janosdebugs @Yantrio @cam72cam! I'd appreciate your quick look over the change to see I'm going in the right direction with the implementation. Thanks!

[Yantrio]

I think the implemtnation here is pretty solid, but I think it may be best to have an external type of validation here instead of using the same code that we're generating with.

Maybe it could be as simple as piping it into JQ and ensuring it's valid json?

@janosdebugs you raised the initial issue, when you mention "valid" json, do you mean that it's valid json, or valid to our format and what we expected?

[ghost]

@Yantrio as I wrote in the related issue, I would like the JSON to be valid from the perspective of the registry, ideally. However, this may also be covered by #164.

[kislerdm]

@janosdebugs @Yantrio Hey folks! Thanks for the feedback. On its basis, I'll remove introduced code and setup a github action which will read modified metafile using jq, and implement the content validation as part of #164.

[ghost]

To clarify: I'm not unhappy with a Go solution, it feels more robust than shell scripting around it. That being said, I don't know the registry very well, so I'll have to rely on the more experienced colleagues for judgement here.

[kislerdm]

@janosdebugs @Yantrio hey guys! The validator is ready for review.

[Yantrio]

thanks for this @kislerdm , I've added 2 tiny tiny nitpicks but overall im happy to approve.

[kislerdm]

@Yantrio good catch, thank you James! 😄

[kislerdm]

@janosdebugs Hey Janos! Could you please review the changes? Thanks!

[ghost]

Very nice and thorough work, thank you!