-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIDCS-3351: Add sample leveraging foreground services #522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left a few typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Looking good. Left some comments. Please, have a look.
.github/workflows/build-basic-video-chat-with_foregroundservices-java.yml
Outdated
Show resolved
Hide resolved
Basic-Video-Chat-With-ForegroundServices-Java/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
…es-java.yml Co-authored-by: Jose Olivera Ortega <[email protected]>
…amples into VIDCS-3351
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, r=me.
I would add support for a matrix in a single workflow file and remove all https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows/build-*
workflows files.
This PR is already very extense. I will create a new one |
Currently, only foreground service being used is to keep microphone capturing when the app moves to background.