Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIDCS-3351: Add sample leveraging foreground services #522

Merged
merged 11 commits into from
Feb 11, 2025

Conversation

goncalocostamendes
Copy link
Contributor

Currently, only foreground service being used is to keep microphone capturing when the app moves to background.

Copy link

@juliobecerragomez juliobecerragomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a few typos.

Basic-Video-Chat-With-ForegroundServices-Java/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@joliveraortega joliveraortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Looking good. Left some comments. Please, have a look.

Copy link
Contributor

@joliveraortega joliveraortega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me.

I would add support for a matrix in a single workflow file and remove all https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows/build-* workflows files.

@goncalocostamendes
Copy link
Contributor Author

LGTM, r=me.

I would add support for a matrix in a single workflow file and remove all https://github.com/opentok/opentok-android-sdk-samples/tree/main/.github/workflows/build-* workflows files.

This PR is already very extense. I will create a new one

@goncalocostamendes goncalocostamendes merged commit 2709d6d into main Feb 11, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants