Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to basic video chat sample #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add logging to basic video chat sample #90

wants to merge 1 commit into from

Conversation

robjperez
Copy link
Contributor

No description provided.

@robjperez robjperez requested a review from msach22 July 3, 2019 16:02
@msach22
Copy link
Contributor

msach22 commented Mar 30, 2020

@robjperez The logger looks good, can we update the SDK dependency to 2.16.5?

msach22
msach22 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@msach22 msach22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update to 2.16.5 if you can!

@mheap mheap changed the base branch from master to main March 22, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msach22 msach22 msach22 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robjperez @msach22