Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for skipPattern in servletcontext if none is defined by Builder #97

Closed
wants to merge 2 commits into from
Closed

Search for skipPattern in servletcontext if none is defined by Builder #97

wants to merge 2 commits into from

Conversation

wyfrel
Copy link

@wyfrel wyfrel commented Sep 16, 2018

Allow configuration of skipPattern via a ServletContext attribute if none is define via the constructor of ServerTracingFilter (a bit like in (https://github.com/opentracing-contrib/java-web-servlet-filter/blob/master/opentracing-web-servlet-filter/src/main/java/io/opentracing/contrib/web/servlet/filter/TracingFilter.java)

@wyfrel
Copy link
Author

wyfrel commented Sep 16, 2018

Fixes #96

@pavolloffay
Copy link
Collaborator

@wyfrel thanks for the PR I will close this re comments in #96.

I will start a new issue regarding configuration via web.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants