Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show generalized cost in debug UI #6336

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Dec 16, 2024

Summary

This adds the generalized cost for legs and itineraries to the debug UI. It looks like this:

image

In order to make some room, I formatted the leg duration a bit more compactly.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.85%. Comparing base (31c40f7) to head (edcba5a).
Report is 35 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6336   +/-   ##
==========================================
  Coverage      69.84%   69.85%           
- Complexity     17907    17921   +14     
==========================================
  Files           2034     2035    +1     
  Lines          76444    76495   +51     
  Branches        7820     7824    +4     
==========================================
+ Hits           53396    53434   +38     
- Misses         20315    20324    +9     
- Partials        2733     2737    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miklcct
Copy link
Contributor

miklcct commented Dec 16, 2024

I think that the use of a dollar sign may be a bit misleading, as the generalized cost is measured in terms of time, not in terms of money. This is particularly relevant if we are going to show the fare information in the debug UI as well.

Copy link
Contributor

@testower testower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@leonardehrenfried leonardehrenfried merged commit b04dc99 into opentripplanner:dev-2.x Dec 17, 2024
6 checks passed
@leonardehrenfried leonardehrenfried deleted the debug-ui-cost branch December 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTP Debug UI The OTP bundled client Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants