Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 minor LSP errors #6374

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

cedarbaum
Copy link
Contributor

Summary

This PR makes two small fixes to avoid reporting errors in the Java language server used by VSCode (version JavaSE-21):

  • Annotate OccupancyStatus with its enum type, as is done for other DocumentedEnum implementations.
  • Move TestDataFetcherDecorator to its correct package path.

With these 2 fixes, the LSP now reports no errors and only warnings.

Though these changes do not affect compilation when using mvn (and I assume are treated as warnings in IntelliJ and/or other Java compilers/lsps), I believe they are both good/safe changes regardless of IDE or Java version compatibility.

Issue

N/A

Unit tests

Existing compilation and unit tests should be sufficient to cover these small changes.

Documentation

N/A

Changelog

skip changelog tag should be used for this change.

Bumping the serialization version id

N/A

@cedarbaum cedarbaum requested a review from a team as a code owner January 10, 2025 01:17
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (969fb44) to head (e23144b).
Report is 5 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6374      +/-   ##
=============================================
- Coverage      69.80%   69.80%   -0.01%     
+ Complexity     17943    17941       -2     
=============================================
  Files           2046     2046              
  Lines          76671    76671              
  Branches        7830     7830              
=============================================
- Hits           53520    53518       -2     
- Misses         20408    20410       +2     
  Partials        2743     2743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonardehrenfried leonardehrenfried merged commit 025e4c4 into opentripplanner:dev-2.x Jan 10, 2025
5 checks passed
@leonardehrenfried
Copy link
Member

I've taken the liberty to skip the second reviewer.

@cedarbaum cedarbaum deleted the fix_lsp_errors branch January 10, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants