[GPU] Moved RMSFusion higher in pipeline and added output type fuse #27564
+57
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: transformations
Lyamin-Roman
force-pushed
the
rms_fuse
branch
2 times, most recently
from
66ab616
to
05cfd75
Compare
Lyamin-Roman
force-pushed
the
rms_fuse
branch
from
05cfd75
to
a0bbe8e
Compare
sshlyapn
reviewed
Nov 18, 2024
| @@ -465,7 +467,8 @@ bool ov::pass::ConvertPrecision::run_on_model(const std::shared_ptr<ov::Model>& | |||
| {ov::op::v0::PriorBox::get_type_info_static(), fuse_type_to_prior_box<ov::op::v0::PriorBox>}, | |||
| {ov::op::v8::PriorBox::get_type_info_static(), fuse_type_to_prior_box<ov::op::v8::PriorBox>}, | |||
| {ov::op::v0::PriorBoxClustered::get_type_info_static(), fuse_type_to_prior_box<ov::op::v0::PriorBoxClustered>}, | |||
| {ov::op::v15::SearchSorted::get_type_info_static(), fuse_type_to_search_sorted_v15}}; | |||
| {ov::op::v15::SearchSorted::get_type_info_static(), fuse_type_to_search_sorted_v15}, | |||
| {ov::op::internal::RMS::get_type_info_static(), fuse_type_to_rms}}; | |||
There was a problem hiding this comment.
Looks good to me. One question: does CPU plugin support this type fusion?
praasz
reviewed
Nov 18, 2024
| @@ -43,6 +43,12 @@ class TRANSFORMATIONS_API RMS : public ov::op::Op { | |||
| m_epsilon = epsilon; | |||
| } | |||
|
|
|||
| void set_output_type(const element::Type& output_type) { | |||
There was a problem hiding this comment.
Rename this memeber to avoid masking base class member then
using Node::set_output_type;
should not be requried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: