turn on first row check for setup

openvm-org · Jan 10, 2025 · 42d8191 · 42d8191
1 parent 928ab04
commit 42d8191
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/circuits/mod-builder/src/builder.rs b/crates/circuits/mod-builder/src/builder.rs
@@ -289,6 +289,8 @@ impl<AB: InteractionBuilder> SubAir<AB> for FieldExpr {
         if self.builder.needs_setup() {
             let is_setup = flags.iter().fold(is_valid.into(), |acc, &x| acc - x);
             builder.assert_bool(is_setup.clone());
+            // TODO: turn back on once we also support this in ecc and everywhere
+            builder.when_first_row().assert_one(is_setup.clone());
             for i in 0..inputs[0].len().max(self.builder.prime_limbs.len()) {
                 let lhs = if i < inputs[0].len() {
                     inputs[0][i].into()
@@ -318,9 +320,6 @@ impl<AB: InteractionBuilder> SubAir<AB> for FieldExpr {
             })
             .collect();
 
-        // TODO: turn back on once we also support this in ecc and everywhere
-        // builder.when_first_row().assert_one(is_setup);
-
         for flag in flags.iter() {
             builder.assert_bool(*flag);
         }