Clean up todos/fixmes

openvm-org · Jan 6, 2025 · 5135348 · 5135348
1 parent 1be8820
commit 5135348
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/crates/vm/src/system/memory/controller/mod.rs b/crates/vm/src/system/memory/controller/mod.rs
@@ -267,7 +267,6 @@ impl<F: PrimeField32> MemoryController<F> {
         compression_bus: DirectCompressionBus,
         initial_memory: MemoryImage<F>,
     ) -> Self {
-        // TODO[zach]: Avoid cloning initial_memory.
         let memory_dims = MemoryDimensions {
             as_height: mem_config.as_height,
             address_height: mem_config.pointer_max_bits - log2_strict_usize(CHUNK),
@@ -688,7 +687,6 @@ impl<F: PrimeField32> MemoryController<F> {
     }
 }
 
-// TODO[zach]: We can probably deprecate this and just provide this interface in `OfflineMemory`.
 #[derive(Clone, Debug)]
 pub struct MemoryAuxColsFactory<T> {
     range_checker: Arc<VariableRangeCheckerChip>,

diff --git a/extensions/keccak256/circuit/src/tests.rs b/extensions/keccak256/circuit/src/tests.rs
@@ -78,13 +78,6 @@ fn build_keccak256_test(
                 assert_eq!(tester.read_cell(e, dst + i), F::from_canonical_u8(*byte));
             }
         }
-        // FIXME[zach]
-        // if let Some(output) = prank_output {
-        //     for (i, output_byte) in output.iter().enumerate() {
-        //         chip.records.last_mut().unwrap().digest_writes[i / KECCAK_WORD_SIZE].data
-        //             [i % KECCAK_WORD_SIZE] = F::from_canonical_u8(*output_byte);
-        //     }
-        // }
         // shift dst to not deal with timestamps for pranking
         dst += 32;
     }