Skip to content

Commit

Permalink
chore: remove debugging statements
Browse files Browse the repository at this point in the history
  • Loading branch information
stephenh-axiom-xyz committed Jan 10, 2025
1 parent 4a8f7c4 commit 7dfddd2
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 20 deletions.
2 changes: 1 addition & 1 deletion benchmarks/src/bin/fib_e2e.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ async fn main() -> Result<()> {
)?;
let app_committed_exe = commit_app_exe(app_pk.app_fri_params(), exe);

let n = 1u64;
let n = 800_000u64;
let mut stdin = StdIn::default();
stdin.write(&n);
run_with_metric_collection("OUTPUT_PATH", || {
Expand Down
1 change: 0 additions & 1 deletion ci/scripts/bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ def run_cargo_command(
env["RUSTFLAGS"] = "-Ctarget-cpu=native"

# Run the subprocess with the updated environment
print(f"running command: {' '.join(command)}")
subprocess.run(command, check=True, env=env)

print(f"Output metrics written to {output_path}")
Expand Down
1 change: 0 additions & 1 deletion crates/prof/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ impl MetricDb {
sorted_keys.sort();

for label_keys in sorted_keys {
println!("stephenh: label_keys: {:?}", label_keys);
if label_keys.contains(&"cycle_tracker_span".to_string()) {
// Skip cycle_tracker_span as it is too long for markdown and visualized in flamegraphs
continue;
Expand Down
5 changes: 0 additions & 5 deletions crates/sdk/src/prover/halo2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ impl Halo2Prover {
let mut witness = Witness::default();
root_proof.write(&mut witness);
let snark = info_span!("prove", group = "halo2_outer").in_scope(|| {
if self.halo2_pk.profiling {
println!("stephenh: profiling");
} else {
println!("stephenh: not profiling");
}
self.halo2_pk
.verifier
.prove(&self.verifier_srs, witness, self.halo2_pk.profiling)
Expand Down
4 changes: 0 additions & 4 deletions extensions/native/compiler/src/constraints/halo2/compiler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ impl<C: Config + Debug> Halo2ConstraintCompiler<C> {
let mut committed_values_digest = None;
#[cfg(feature = "bench-metrics")]
let mut old_stats = stats_snapshot(ctx, range.clone());
#[cfg(feature = "bench-metrics")]
println!("stephenh: ahhh");
println!("stephenh: start {}", self.profiling);
for (instruction, backtrace) in operations {
#[cfg(feature = "bench-metrics")]
if self.profiling {
Expand Down Expand Up @@ -440,7 +437,6 @@ impl<C: Config + Debug> Halo2ConstraintCompiler<C> {
}
#[cfg(feature = "bench-metrics")]
if self.profiling {
println!("stephenh: halo2 profiling");
let mut new_stats = stats_snapshot(ctx, range.clone());
new_stats.diff(&old_stats);
new_stats.increment(cell_tracker.get_full_name());
Expand Down
8 changes: 0 additions & 8 deletions extensions/native/compiler/src/constraints/halo2/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,10 @@ impl Halo2Stats {

#[cfg(feature = "bench-metrics")]
mod emit {
use std::sync::atomic::AtomicUsize;

use metrics::counter;

use super::Halo2Stats;

static PRINT_COUNT: AtomicUsize = AtomicUsize::new(0);

impl Halo2Stats {
pub fn diff(&mut self, another: &Self) {
*self = Self {
Expand All @@ -37,10 +33,6 @@ mod emit {
counter!("simple_advice_cells", &labels).increment(self.total_gate_cell as u64);
counter!("fixed_cells", &labels).increment(self.total_fixed as u64);
counter!("lookup_advice_cells", &labels).increment(self.total_lookup_cell as u64);
if PRINT_COUNT.load(std::sync::atomic::Ordering::Relaxed) < 100 {
tracing::info!("stephenh: total_gate_cell: {}", self.total_gate_cell);
PRINT_COUNT.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
}
}
}
}

0 comments on commit 7dfddd2

Please sign in to comment.