fix abs for int mul (#759)

openvm-org · Nov 5, 2024 · 90781a8 · 90781a8
1 parent 53bee35
commit 90781a8
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/circuits/ecc/src/field_expression/symbolic_expr.rs b/circuits/ecc/src/field_expression/symbolic_expr.rs
@@ -40,7 +40,7 @@ impl std::fmt::Display for SymbolicExpr {
             SymbolicExpr::Var(i) => write!(f, "Var({})", i),
             SymbolicExpr::Add(lhs, rhs) => write!(f, "({} + {})", lhs, rhs),
             SymbolicExpr::Sub(lhs, rhs) => write!(f, "({} - {})", lhs, rhs),
-            SymbolicExpr::Mul(lhs, rhs) => write!(f, "({} * {})", lhs, rhs),
+            SymbolicExpr::Mul(lhs, rhs) => write!(f, "{} * {}", lhs, rhs),
             SymbolicExpr::Div(lhs, rhs) => write!(f, "({} / {})", lhs, rhs),
             SymbolicExpr::IntAdd(lhs, s) => write!(f, "({} + {})", lhs, s),
             SymbolicExpr::IntMul(lhs, s) => write!(f, "({} x {})", lhs, s),
@@ -219,7 +219,11 @@ impl SymbolicExpr {
             SymbolicExpr::IntMul(lhs, s) => {
                 let (lhs_max_pos, lhs_max_neg) = lhs.max_abs(prime);
                 let scalar = BigUint::from_usize(s.unsigned_abs()).unwrap();
-                (lhs_max_pos * &scalar, lhs_max_neg * &scalar)
+                if *s < 0 {
+                    (lhs_max_neg * &scalar, lhs_max_pos * &scalar)
+                } else {
+                    (lhs_max_pos * &scalar, lhs_max_neg * &scalar)
+                }
             }
             SymbolicExpr::Select(_, lhs, rhs) => {
                 let (lhs_max_pos, lhs_max_neg) = lhs.max_abs(prime);