Skip to content

Commit

Permalink
fix(castf): handle range check correctly for padding rows (#1206)
Browse files Browse the repository at this point in the history
* bug(castf): LogUp multiset equality check failed

* fix: only range_check on valid rows

---------

Co-authored-by: Yi Sun <[email protected]>
  • Loading branch information
lispc and yi-sun authored Jan 11, 2025
1 parent 37b4f3b commit e1c9244
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion extensions/native/circuit/src/castf/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ where
_ => unreachable!(),
},
)
.eval(builder, AB::Expr::ONE);
.eval(builder, cols.is_valid);
}

AdapterAirContext {
Expand Down
2 changes: 1 addition & 1 deletion extensions/native/circuit/src/castf/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ fn castf_rand_test() {
CastFCoreChip::new(tester.range_checker(), 0),
tester.offline_memory_mutex_arc(),
);
let num_tests: usize = 1;
let num_tests: usize = 3;

for _ in 0..num_tests {
let y = generate_uint_number(&mut rng);
Expand Down

0 comments on commit e1c9244

Please sign in to comment.