Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move build comments to CLI help descriptors #1016

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: Move build comments to CLI help descriptors #1016

merged 2 commits into from
Dec 13, 2024

Conversation

stephenh-axiom-xyz
Copy link
Contributor

Also moves CLI test to a tests directory to match our other crates.

Golovanov399
Golovanov399 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Golovanov399 Golovanov399 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Does it change anything though?

@stephenh-axiom-xyz
Copy link
Contributor Author

Will push this after rename btw, but it makes it so the CLI --help is more descriptive ig? Nothing else beyond that

jonathanpwang
jonathanpwang approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from some minor comments

@stephenh-axiom-xyz stephenh-axiom-xyz merged commit 2857d92 into main Dec 13, 2024
4 checks passed
@stephenh-axiom-xyz stephenh-axiom-xyz deleted the chore/cli-clean-0 branch December 13, 2024 01:06
luffykai pushed a commit that referenced this pull request Dec 13, 2024
@stephenh-axiom-xyz
chore: Move build comments to CLI help descriptors (#1016)
7d28eb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@Golovanov399 Golovanov399 Golovanov399 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenh-axiom-xyz @Golovanov399 @jonathanpwang