Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default paths for CLI keygen, proving, and verification #1027

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

stephenh-axiom-xyz
Copy link
Contributor

Resolves INT-2862.

  • Outputs for keygen and prove are written to a default location if no path is provided
  • Inputs for prove and verify are read from a default location if no path is provided
  • NOTE: Users still need to specify the location of their config TOML and vmexe.

Copy link

linear bot commented Dec 13, 2024

INT-2862 CLI uses current directory by default + setup fixes

keygen/prove/execute/verify CLI commands need to specify lots of arguments about App VM proving key/Exe. We should read/write them into the current directory by default

Also, setup should a) check if solc is installed (and fail quickly with an error prompt if so) and b) download kzg files into ./openvm/params/. We should specify the amount of memory needed to run setup in the warning.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit aca1216 into main Dec 13, 2024
8 checks passed
@jonathanpwang jonathanpwang deleted the feat/cli-default-paths branch December 13, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants