Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Clean up legacy access adapter code #1032

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

nyunyunyunyu
Copy link
Contributor

No description provided.

@nyunyunyunyu nyunyunyunyu added run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e labels Dec 13, 2024
@nyunyunyunyu nyunyunyunyu force-pushed the chore/mem-fin-trace-gen branch from b972b89 to f218874 Compare December 13, 2024 19:36
@nyunyunyunyu nyunyunyunyu changed the title [chore] Move finalize out of execution [chore] Clean up legacy access adapter code Dec 13, 2024
Copy link

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
10,251,804
195,066
(+20.0 [+1.0%])
2,002.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,615,800
3,000,274
(-107.0 [-1.9%])
5,507.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
238,890,449
8,381,808
(-677.0 [-3.9%])
16,853.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(+1,190 [+0.0%])
48,127,077
(+140 [+0.0%])
397,234
(+57.0 [+1.8%])
3,142.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

E2E Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms root_log_blowup root_total_cells_used root_total_cycles root_total_proof_time_ms internal_log_blowup internal_total_cells_used internal_total_cycles internal_total_proof_time_ms max_segment_length instance alloc
app_proof
2
411,172,110
24,000,274
38,379.0
-
-
-
-
-
-
-
-
2
853,364,606
43,358,300
80,139.0
1048476 64cpu-linux-arm64 mimalloc

Commit: 7bead81

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 75674cd into main Dec 14, 2024
11 of 12 checks passed
@jonathanpwang jonathanpwang deleted the chore/mem-fin-trace-gen branch December 14, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants