Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric_unify): refactor and add diff command #1165

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Jan 3, 2025

Resolve #1155

Usage:

metric_unify summary --metrics-json <METRICS_JSON>

metric_unify aggregate --metrics-json <METRICS_JSON> --aggregation-json <AGGREGATION_JSON>

metric_unify diff --metrics-json <METRICS_JSON> --prev-metrics-json <PREV_METRICS_JSON>

The "main" branch has significant changes, need to resolve conflicts.

@keroro520 keroro520 marked this pull request as draft January 3, 2025 17:48
@jonathanpwang
Copy link
Contributor

The way I have it set up now, diff is auto detected if the optional arg --prev-json-paths is provided

@jonathanpwang
Copy link
Contributor

@keroro520 just checking if you needed any help here (no rush)

@keroro520
Copy link
Contributor Author

@keroro520 just checking if you needed any help here (no rush)

Thank you for your kind reminder @jonathanpwang
I've been struggling with other tasks lately and will take some time to resolve the conflicts asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add diffs to detailed metrics
2 participants