Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iterator-based for loops #1176
feat: add iterator-based for loops #1176
Changes from 39 commits
d967ac7
2c53f1a
b07c4ea
674f894
df77c86
1190233
43e7a86
2b84329
9f6a3e6
cd7fcbf
3378cc2
2ac690c
a64cb2b
56bff31
6533f8d
053a4ee
5d72e21
7dc4557
8c27cdf
f71efd7
9266fba
6851b5a
9d9c5c4
9b4cc0e
f85ae11
c9aa05e
45134ad
84c9d75
8e8b062
2e68d6e
f5cc632
0aff4b0
46ddb6b
392355b
beae4ce
2d5a26e
7d8670b
8fc92db
df89bb1
71c958b
e0886a8
4a1d614
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small optimization: We can put the
Bne
after the firstAddFI
so that we don't spend cycles incrementing pointers we don't need to use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the first
Bne
to cover the case wherestarts[0] == end0
.