Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Debug derive from chips #1197

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

zlangley
Copy link
Contributor

@zlangley zlangley commented Jan 8, 2025

Derived implementation will recursively print everything, which is not useful. Also causes derive(Debug) to spread to lots of other types that contain the chips.

Derived implementation will recursively print everything, which is not useful.
Also causes derive(Debug) to spread to lots of other types that contain the
chips.
@zlangley zlangley requested a review from jonathanpwang January 8, 2025 18:46
Copy link

github-actions bot commented Jan 8, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-52 [-1.3%]) 3,863 746,291 30,011,984 - - -
fibonacci_program (-52 [-0.8%]) 6,183 1,500,137 51,505,102 - - -
regex_program (+454 [+2.4%]) 19,217 4,190,904 165,028,173 - - -
ecrecover_program (+15 [+0.6%]) 2,614 285,169 15,074,875 - - -

Commit: 4cb0773

Benchmark Workflow

@zlangley zlangley merged commit e8e0558 into main Jan 8, 2025
23 checks passed
@zlangley zlangley deleted the chore/memory-controller-debug branch January 8, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants