Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse native asm src #1198

Closed
wants to merge 2 commits into from
Closed

feat: parse native asm src #1198

wants to merge 2 commits into from

Conversation

lispc
Copy link
Contributor

@lispc lispc commented Jan 9, 2025

No description provided.

This comment has been minimized.

Copy link

github-actions bot commented Jan 9, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-18 [-0.5%]) 3,819 746,355 30,012,764 - - -
fibonacci_program (+38 [+0.6%]) 6,067 1,500,137 51,505,102 - - -
regex_program 18,531 4,190,904 165,028,173 - - -
ecrecover_program (-27 [-1.0%]) 2,601 285,401 15,092,297 - - -

Commit: f9d1403

Benchmark Workflow

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful, but AsmInstruction is an intermediate representation that is not quite pure OpenVM Instruction so I'm not sure we want to keep AsmInstruction at all / encourage its usage.

cc @yi-sun @TlatoaniHJ @zlangley

@yi-sun
Copy link
Collaborator

yi-sun commented Jan 9, 2025

We want to treat AsmInstruction as more of an IR, i.e. we will commit to stabilizing the native extension ISA opcodes relatively soon, but we may add / remove AsmInstruction opcodes at a faster pace.

@lispc
Copy link
Contributor Author

lispc commented Jan 10, 2025

yes later i also have same feeling. seems using rust codes to manipulate "Program" is a better option.

@lispc lispc closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants