Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] turn on first row check for setup #1202

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

luffykai
Copy link
Contributor

No description provided.

This comment has been minimized.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+35 [+0.9%]) 3,829 746,003 30,007,494 - - -
fibonacci_program (-44 [-0.7%]) 6,059 1,500,137 51,505,102 - - -
regex_program (-97 [-0.5%]) 18,439 4,190,904 165,028,173 - - -
ecrecover_program (+13 [+0.5%]) 2,616 285,401 15,092,297 - - -

Commit: 0197c03

Benchmark Workflow

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge now but we have some separate discussions around cleaning up setup more generally and need to figure out how to handle pairing chips

@jonathanpwang jonathanpwang merged commit cb48e25 into main Jan 10, 2025
9 checks passed
@jonathanpwang jonathanpwang deleted the lunkai/setup-check branch January 10, 2025 19:58
@jonathanpwang
Copy link
Contributor

note: this does not count as a security bug in the chips because you can inspect the program to see if setup was ever called. We were previously enforcing setup at the level of program correctness, but of course it's better to be able to enforce it at the chip level.

@jonathanpwang
Copy link
Contributor

@luffykai for some reason this failed after pushing to main but not in PR

@yi-sun
Copy link
Collaborator

yi-sun commented Jan 11, 2025

Looks like the algebra extension test didn't run on this PR -- we should add crates/circuits/mod-builder/** to the triggering paths in the workflow.

@jonathanpwang
Copy link
Contributor

#1204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants