Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make CASTF unit test match #1210

Closed
wants to merge 3 commits into from
Closed

Conversation

jonathanpwang
Copy link
Contributor

#1206 (comment)

It doesn't matter for unit test because unit tester doesn't check against program code, but fixing the unit test so the usage matches how it should be used in practice.

We will more thoroughly address a better handling of offsets soon.

@jonathanpwang
Copy link
Contributor Author

cc @lispc

This comment has been minimized.

This comment has been minimized.

@jonathanpwang
Copy link
Contributor Author

closing to address in general offset cleanup because other tests just set offset=0

@jonathanpwang jonathanpwang deleted the chore/castf-test branch January 12, 2025 23:52
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+332 [+9.5%]) 3,817 (+35063 [+4.9%]) 746,347 (+4502019 [+17.6%]) 30,012,964 - - -
fibonacci_program (+9 [+0.1%]) 6,076 1,500,137 51,505,102 - - -
regex_program (+160 [+0.8%]) 19,156 4,190,904 165,028,173 - - -
ecrecover_program (-18 [-0.7%]) 2,576 285,401 15,092,297 - - -

Commit: 865af5a

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant