Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement Stateful for VmChipComplex #1211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nyunyunyunyu
Copy link
Contributor

@nyunyunyunyu nyunyunyunyu commented Jan 13, 2025

1st commit:

  • Implement Stateful for system chips.
  • Implement SharedVariableRangeCheckerChip.

2st commit:

  • Implement Stateful for VmChipComplex.
  • Add ExecutionSegment::new_for_proving which constructs a ExecutionSegment just for proving.
  • Add ExecutionSegment::store_chip_complex_state to store states.

Note: some memory states need to clone. We should to try to avoid it in the future.

closes INT-2951

@nyunyunyunyu nyunyunyunyu changed the title [HOLD][feat] Implement Stateful for SystemComplex [feat] Implement Stateful for VmChipComplex Jan 13, 2025
@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review January 13, 2025 15:25
@nyunyunyunyu nyunyunyunyu force-pushed the feat/impl-state-persist branch from 51eace6 to a7fef1a Compare January 13, 2025 16:40
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+22 [+0.6%]) 3,497 711,327 25,511,375 - - -
fibonacci_program (+67 [+1.1%]) 6,123 1,500,137 51,505,102 - - -
regex_program (+19 [+0.1%]) 18,950 4,190,904 165,028,173 - - -
ecrecover_program (+20 [+0.8%]) 2,622 285,401 15,092,297 - - -

Commit: a7fef1a

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant