Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is the PR for #1029 which implements metrics recorder for Prometheus. Previous discussion can be found in #1201.
The PR implements a recoder that:
[metrics_context_tracing](https://docs.rs/metrics-tracing-context/latest/metrics_tracing_context/)
enabled( as stated in the docs). so any metric recorded within a span, the span is automatically added as a metric label. However, this does not apply to the process metrics metrics regularly collected in the previous point, because they run in a separate thread.Usage: In this repo, I made two examples how the memory profiler could work with both (pull/push) prometheus exporters.