-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MemoryAccessAdapter #455
Conversation
8a9f8f2
to
bca10d2
Compare
bca10d2
to
ef7b827
Compare
INT-2169 Make compiler changes to ensure instruction operands are block-aligned INT-1939 Memory support variable word size
Using the Mittal interaction argument: https://docs.google.com/document/d/1n1FU64ej0VGSRHRMHuf12gEanTT8HHwqEf3NAiTTo6Q/edit We can do this concurrently with no-cpu switch since it only affects memory interface. |
This comment has been minimized.
This comment has been minimized.
ef7b827
to
30c5dbd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
30c5dbd
to
30f2395
Compare
2cac386
to
a153ab4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
* feat: field expression framework * test pass * update readme * range check vars * scalar mul and ec double * address comment * update readme * address comments * check the result in tests * rename
* Add trait BaseAirWithPublicValues * Keygen doesn't need to pass the number of public values
* feat: Keccak batch reads and use of AlignedBorrow * Fix timestamp * feat: add a separate memory block to select for when partial block read * chore: todo comment on switching to range check output --------- Co-authored-by: Jonathan Wang <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fix: the verifier program for keccak was going OOM when compiler set word_size to 64: |
vm_verify_fibair
Flamegraphs: link |
tiny_e2e
Flamegraphs: link |
vm_verify_fibair
Flamegraphs: link |
tiny_e2e
Flamegraphs: link |
77efe63
to
712dae2
Compare
tiny_e2e
Flamegraphs: link |
vm_verify_fibair
Flamegraphs: link |
small_e2e
Flamegraphs: link |
tiny_e2e
Flamegraphs: link |
vm_verify_fibair
Flamegraphs: link |
small_e2e
Flamegraphs: link |
* feat: MemoryAccessAdapter * Compiler changes * Better stack layout * Change stack/heap layout * perf: Make duplex challenger more efficient * fix flamegraph for dsl * Use stack memory more compactly * Comments * Use IsLessThanAir rather than AssertLessThanAir * feat: field expression framework (#470) * feat: field expression framework * test pass * update readme * range check vars * scalar mul and ec double * address comment * update readme * address comments * check the result in tests * rename * Ignore `bench_metrics` in .gitignore (#476) * [refactor] AIR with Public Values (#477) * Add trait BaseAirWithPublicValues * Keygen doesn't need to pass the number of public values * feat: Keccak batch reads and use of AlignedBorrow (#475) * feat: Keccak batch reads and use of AlignedBorrow * Fix timestamp * feat: add a separate memory block to select for when partial block read * chore: todo comment on switching to range check output --------- Co-authored-by: Jonathan Wang <[email protected]> * fix merge * fix: change default compiler `word_size=8` * fix: ecc test compiler word size * chore: mod arith test word size --------- Co-authored-by: luffykai <[email protected]> Co-authored-by: Golovanov399 <[email protected]> Co-authored-by: Xinding Wei <[email protected]> Co-authored-by: Jonathan Wang <[email protected]>
Closes INT-2169 and INT-1939