[fix] Dynamic verifier doesn't require the order of AIRs #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INT-2104 Add a mapping between trace -> air idx in verifier program
The order of the vkey is still going to be determined at compile time. That gives each AIR an Since the traces of AIRs need to be sorted outside of th program, the program will need another input of For now we will do a bitmap check that each AIR is used in a trace at most once to ensure uniqueness guarantees (e.g., of Audit chip) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
fix/recursion-no-order-requir
branch
from
926a4d0 to
549762a
Compare
nyunyunyunyu
force-pushed
the
fix/recursion-no-order-requir
branch
from
549762a to
743c50c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanpwang
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
LGTM, some comments to add more clarification comments.
Summary
There are two ways to support having non-deterministic trace height ordering in verifier.
- Impose assumptions on the format of the proof. For example the prover must have already sorted traces in descending order before it did MMCS commitments.
- Supply a permutation of the sorted indices as hint and use it to lookup the correct ordering when necessary.
(2) is more general as it allows verifying any proof in plonky3 without adding conditions to the prover. This PR implements both 1+2, where the implementation takes an optional flag to distinguish when the input is already sorted versus when permutation lookup must be done in circuit.
It currently does not support unused Air traces compared to the Air list in the vkey.
There is also an assumption currently that each AIR has exactly one partition of the partitioned main trace that is commited together in a big commitment. For each AIR any other partition, if it exists, is committed in a separate standalone commitment.
Co-authored-by: Jonathan Wang <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
vm_verify_fibair
Flamegraphs: link |
|
tiny_e2e
Flamegraphs: link |
|
small_e2e
Flamegraphs: link |
To clarify: This order thing is a requirement from |
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Dynamic verifier doesn't require the order of AIRs * Fix quotient matrices permutation * Fix static verifier * Fix comments Co-authored-by: Jonathan Wang <[email protected]> * Fix comments --------- Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes INT-2104