You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves INT-2156 INT-2238. Adds end-to-end benchmark for 256-bit integer ALU operations as defined in the spec. Should be run automatically alongside small_e2e and tiny_e2e.
We already have add and sub in the existing UintArithmeticVmChip (we determined that two's complement representation means the chip implementation is the same for signed vs unsigned.)
We will want to share constraints and trace cells between as many of these opcodes as possible. This is typically done by putting everything into the same ALU (arithmetic logical unit) chip as in normal processors. The UintArithmeticVmChip should be extended & renamed for this functionality (at least for some of the opcodes).
The opcode format depends on INT-2149 — I think we should stick with the one level of indirection (to support stack+register access), but we should have a discussion.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-2156 INT-2238. Adds end-to-end benchmark for 256-bit integer ALU operations as defined in the spec. Should be run automatically alongside
small_e2e
andtiny_e2e
.