-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mul_023_by_023 #735
feat: mul_023_by_023 #735
Conversation
ytham
commented
Oct 31, 2024
•
edited
Loading
edited
- Adds mul_023_by_023
- Refactor ecc/lines into d_type and m_type for clearer testing
- Refactor ecc test_utils
temporarily changing base to #712 until it's merged for easier diffing |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jonathanpwang figured it out; ready for review again. source of the confusion was that a lot of the tests reused the LIMB_BITS const for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
let expr = mul_023_by_023_expr( | ||
config, | ||
memory_controller.borrow().range_checker.bus(), | ||
BLS12381.XI, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XI should be part of the constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 2cff345
let mut tester: VmChipTestBuilder<F> = VmChipTestBuilder::default(); | ||
let expr = mul_013_by_013_expr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Detailed Metrics
Commit: d4fefd2 |
Detailed Metrics
Commit: d4fefd2 |
Detailed Metrics
Commit: d4fefd2 |
* WIP: need to apply FieldExtension on Fq, Fq2 for mul_013_by_013 test * Fix mul_013_by_013 * WIP: isolate issue * Fix xi * Update IntAdd * fix * Clean up * Add chip for mul_013_by_013 * Update w/ new ExprBuilderConfig paradigm * Remove extraneous items * Fix lints * Add mul_023_by_023, refactor test_utils * Add chips/chip_set items * address PR comments * Additional fixes * Rebase * Rebase * WIP: test is failing at execute * Rename tangent_line_023 * switch test back to pass * Extra clone * Update adapter to use block size * use BLOCK_SIZE const in miller tests to prevent confusion * Fix lint * Update tests to use BLOCK_SIZE const for Rv32VecHeapAdapterChip * chore: move xi to constructor * chore: clippy --------- Co-authored-by: luffykai <[email protected]> Co-authored-by: Jonathan Wang <[email protected]>