-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] fp2 chip #739
[feat] fp2 chip #739
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d3ffc42
to
bd4fc19
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AddSub is ok, but you definitely have some extra unused columns in MulDiv from division. I think perhaps return var from division can be used as z instead.
But since there are many unexpected things happening behind the scenes, I request you to just to write down how many columns you think this AIR should have, and assert it in a test.
6346e09
to
7bdbec4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
number of vars down to 2 🎉 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the fix seems cleaner than the original!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Detailed Metrics
Commit: 39fb5df |
Detailed Metrics
Commit: 39fb5df |
Detailed Metrics
Commit: 39fb5df |
* wip, do the flags first * wip * addsub works * muldiv works * chip * address comment * reduce vars * fix * chore: add assert on number of vars --------- Co-authored-by: Jonathan Wang <[email protected]>
fix INT-2183