Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autotools: detect ASIMD only when in 64-bit #5663

Merged
merged 1 commit into from
Feb 10, 2025
Merged

autotools: detect ASIMD only when in 64-bit #5663

merged 1 commit into from
Feb 10, 2025

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Feb 9, 2025 •
edited
Loading

It doesn't make much sense to run this test if we already know we're on ARMv7 hardware.

Fix: #5656.

ARMv8

:: checking special compiler flags... ARM64
:: checking if gcc supports -fno-strict-aliasing... yes
[...]

:: Target CPU ......................................... aarch64 ASIMD, 64-bit LE
:: Target OS .......................................... linux-gnu
:: Cross compiling .................................... no
:: Legacy arch header ................................. arm64le.h

ARMv7

:: checking special compiler flags... ARM
:: configure: Testing build host's native CPU features
:: checking for NEON... yes
:: checking if gcc supports -fno-strict-aliasing... yes
[...]

:: Target CPU ......................................... armv7l NEON, 32-bit LE
:: Target OS .......................................... linux-gnueabihf
:: Cross compiling .................................... no
:: Legacy arch header ................................. arm32le.h

Instead of:

:: checking special compiler flags... ARM
:: configure: Testing build host's native CPU features
:: checking for NEON... yes
:: checking for ASIMD... yes
:: checking if gcc supports -fno-strict-aliasing... yes
[...]

:: Target CPU ......................................... armv7l ASIMD, 32-bit LE
:: Target OS .......................................... linux-gnueabihf
:: Cross compiling .................................... no
:: Legacy arch header ................................. arm64le.h

@claudioandre-br
Copy link
Member Author

The git diff -w:

@claudioandre-br
autotools: detect ASIMD only when in 64-bit
2065640 
It doesn't make much sense to run this test if we already know we're
on ARMv7 hardware.

Fix: openwall#5656.

Signed-off-by: Claudio André <[email protected]>
magnumripper
magnumripper approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@magnumripper magnumripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@solardiz solardiz merged commit 2e9d4a8 into openwall:bleeding-jumbo Feb 10, 2025
35 checks passed
@claudioandre-br claudioandre-br deleted the fix/autotools branch February 10, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnumripper magnumripper magnumripper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ARM 32-bit issues (again)
3 participants
@claudioandre-br @magnumripper @solardiz