Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD of OIDC clients #250

Merged
merged 9 commits into from
Mar 22, 2023

Conversation

Jsyro
Copy link
Contributor

@Jsyro Jsyro commented Mar 22, 2023

Open to changing the model defaults, kind of a janky way to updating the client repository, hopefully it does not cause any issues later.

Stateless is basically what we are doing.
MongoWrapper is incompatible with our version of PyMongo, IdentityPython/pyop#48
RedisWrapper would be a misuse of redis as we would need to add persistence to it.

@Jsyro Jsyro requested a review from esune March 22, 2023 16:27
@Jsyro Jsyro changed the title CRUD of new clients CRUD of OIDC clients Mar 22, 2023
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one small comment requiring feedback 🙂
I am thinking we also may want to add capability to load a config file, but we can tackle that as a separate issue.

oidc-controller/api/authSessions/crud.py Show resolved Hide resolved
@esune esune merged commit 43ea3db into openwallet-foundation:2.0-development Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants