Fix/redundant sql query during ca cert creation #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SitaGanesh
force-pushed
the
fix/redundant-sql-query-during-ca-cert-creation
branch
from
00723a0 to
11e8c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #168 .
Description of Changes
[base/models] Avoid redundant SQL write query during CA/Cert creation
Refactored the save() method to simplify logic and avoid unnecessary SQL write queries during CA/Certificate creation. Additionally, the test case in
django_x509/tests/test_cert.pywas updated to utilizeassertNumQueries, ensuring a reduction in database queries is verified automatically.Fixes #168.
Screenshot
Please include any relevant screenshots.
