[chores] Cleaned up media property methods

Avoid manipulating private properties from Django.
openwisp · May 3, 2024 · 17e9125 · 17e9125
1 parent 4f579ec
commit 17e9125
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/openwisp_firmware_upgrader/admin.py b/openwisp_firmware_upgrader/admin.py
@@ -105,13 +105,11 @@ class Meta:
 
     @property
     def media(self):
-        media = super().media
-        js = list(media._js) + [
+        js = [
             'firmware-upgrader/js/upgrade-selected-confirmation.js',
         ]
-        css = media._css.copy()
-        css['all'] += ['firmware-upgrader/css/upgrade-selected-confirmation.css']
-        return forms.Media(js=js, css=css)
+        css = {'all': ['firmware-upgrader/css/upgrade-selected-confirmation.css']}
+        return super().media + forms.Media(js=js, css=css)
 
 
 @admin.register(load_model('Build'))

diff --git a/openwisp_firmware_upgrader/widgets.py b/openwisp_firmware_upgrader/widgets.py
@@ -22,7 +22,6 @@ class FirmwareSchemaWidget(BaseJsonSchemaWidget):
 
     @property
     def media(self):
-        media = super().media
-        css = media._css.copy()
-        css['all'] += ['firmware-upgrader/css/upgrade-options.css']
-        return forms.Media(js=media._js, css=css)
+        return super().media + forms.Media(
+            css={'all': ['firmware-upgrader/css/upgrade-options.css']}
+        )