Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.10] netbird: update to 0.36.7 #26002

Merged

Conversation

wehagy
Copy link
Contributor

@wehagy wehagy commented Feb 18, 2025

Draft PR, need testing

Compile and run tested

Maintainer: Me

Package architecture Target Subtarget Brand Model Hardware Version OpenWrt version
x86_64 x86 64 QEMU (x86_64) qemu-system-x86_64 qemu-9.1.2-3.fc41 OpenWrt 24.10-SNAPSHOT r28470-315facfce6

Tests checklist:

  • Connection to the NetBird Cloud Dashboard (not self-hosted).
  • Firewall configured with nftables.
  • Connection established in P2P mode.
  • wireguard kernel mode active.
  • Routes configured between my homelab and my cloud server.
  • netbird DNS server functioning correctly.
  • NAT operational (not needed by me at this time, may consider testing in the future).
  • Permissions rules is enforced (not needed by me at this time, may consider testing in the future).

Description


Additional information

x86_64 is running in a container using incus.
The package(s) was compiled with the container sdk.
The OpenWrt image(s) was built using the container imagebuilder or distrobuilder.

You can view my repository with the patch applied and the automated build here:
This repository is temporary and will be removed or modified after the merge.

You can find my artifacts here:

changelog: https://github.com/netbirdio/netbird/releases/tag/v0.36.7

Signed-off-by: Wesley Gimenes <[email protected]>
(cherry picked from commit 7ff04e9)
@wehagy
Copy link
Contributor Author

wehagy commented Feb 18, 2025

Unrelated CI Errors:

 Updated list of available packages in /var/opkg-lists/packages_ci
Downloading file:///ci/Packages.sig
Signature check passed.
 * opkg_download: Failed to download https://downloads.openwrt.org/releases/24.10-SNAPSHOT/targets/x86/64/kmods/6.6.58-1-cccdb39f40ab0d2ddc0a71725516d8a8/Packages.gz, wget returned 8.
Error: Process completed with exit code 1.

@wehagy wehagy marked this pull request as ready for review February 18, 2025 01:49
@jclds139
Copy link

I'd just like to add that this update contains workarounds that resolve several painful bugs (see netbirdio/netbird#2530 and netbirdio/netbird#2116) that have been breaking the current package for many of us. Hoping this can get merged and included in a release soon!

@wehagy
Copy link
Contributor Author

wehagy commented Feb 19, 2025

From what I can see, these bugs affect a third-party OpenWrt downstreams, unfortunaly I can make nothing to help, this comment netbirdio/netbird#2116 (comment) show that the issue is resolved by using an official OpenWrt image. In fact, the latest stable release, OpenWrt 24.10, has been updated with netbird v0.36.3, which was released just a month ago.

PKG_VERSION:=0.36.3

I don't recommend using the older stable release, OpenWrt 23.05, as it will soon reach its end of life and is stuck on a very outdated version of netbird v0.24.3 probably forever.

PKG_VERSION:=0.24.3

@jclds139
Copy link

jclds139 commented Feb 19, 2025

Unfortunately, I'm running into those same issues with a proper 24.10.0 install. Currently, I have to manually add the environment variables NB_DISABLE_CUSTOM_ROUTING=true and NB_SKIP_SOCKET_MARK=true or else netbird is constantly timing out trying to connect to the management api.

My point was to whoever does the reviews that there are needed bugfixes currently held up by this PR.

@wehagy
Copy link
Contributor Author

wehagy commented Feb 19, 2025

Strange my test and stable environment is working normally, you are running a fresh OpenWrt with only netbird installed? If not, what packages you install? Do you mind to show your netbird logs? cat /var/log/netbird/client.log.

@jclds139
Copy link

jclds139 commented Feb 20, 2025 via email

@jclds139
Copy link

jclds139 commented Feb 20, 2025

Update: can confirm, the issue is resolved once there is no iptables binary on the system. I'm not sure if that's something that should be documented somewhere or if it's an issue to raise upstream, though.
Unfortunately, while I can remove mwan3 and thus iptables* on one of my routers, I have several others that rely on the failover functionality from mwan3. Do you know any way to get netbird to use nftables even though iptables-nft is also available? I suspect that may also solve the issue.

@1715173329 1715173329 merged commit 5908ba1 into openwrt:openwrt-24.10 Feb 20, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants