PR #22800: Change the default value of print_operand_shape_ to false and print_large_constants_ to true. #23028
+1,463
−1,419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_730428975
branch
4 times, most recently
from
c48c09b to
3f1c0c1
Compare
…and print_large_constants_ to true. Imported from GitHub PR #22800 Operand shape in long hlo text adds redundant information, which shouldn't be required. Changing the default value to off. The large constants were also printed earlier by default print options, and it is required for parsability and reproducibility. Turning this on by default. This is still controlled by debug option and the default value of that flag disables the large constants, and that behavior is not changed. Just the default print options change here. Copybara import of the project: -- e30dea2 by Shraiysh Vaishay <[email protected]>: Change the default value of print_operand_shape_ to false and print_large_constants_ to true. Operand shape in long hlo text adds redundant information, which shouldn't be required. Changing the default value to off. The large constants were also printed earlier by default print options, and it is required for parsability and reproducibility. Turning this on by default. This is still controlled by debug option and the default value of that flag disables the large constants, and that behavior is not changed. Just the default print options change here. -- 7008af0 by Shraiysh Vaishay <[email protected]>: Handle tests -- b22d5f9 by Shraiysh Vaishay <[email protected]>: Fix more tests -- d51579c by Shraiysh Vaishay <[email protected]>: Fix more tests Merging this change closes #22800 FUTURE_COPYBARA_INTEGRATE_REVIEW=#22800 from shraiysh:change_default_print_op_shape d51579c PiperOrigin-RevId: 730428975
copybara-service
bot
force-pushed
the
test_730428975
branch
from
3f1c0c1 to
77fd8e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #22800: Change the default value of print_operand_shape_ to false and print_large_constants_ to true.
Imported from GitHub PR #22800
Operand shape in long hlo text adds redundant information, which shouldn't be required. Changing the default value to off.
The large constants were also printed earlier by default print options, and it is required for parsability and reproducibility. Turning this on by default. This is still controlled by debug option and the default value of that flag disables the large constants, and that behavior is not changed. Just the default print options change here.
Copybara import of the project:
--
e30dea2 by Shraiysh Vaishay [email protected]:
Change the default value of print_operand_shape_ to false and print_large_constants_ to true.
Operand shape in long hlo text adds redundant information, which
shouldn't be required. Changing the default value to off.
The large constants were also printed earlier by default print options,
and it is required for parsability and reproducibility. Turning this on by default.
This is still controlled by debug option and the default value of that
flag disables the large constants, and that behavior is not changed. Just the
default print options change here.
--
7008af0 by Shraiysh Vaishay [email protected]:
Handle tests
--
b22d5f9 by Shraiysh Vaishay [email protected]:
Fix more tests
--
d51579c by Shraiysh Vaishay [email protected]:
Fix more tests
Merging this change closes #22800
FUTURE_COPYBARA_INTEGRATE_REVIEW=#22800 from shraiysh:change_default_print_op_shape d51579c