PR #23181: Annotate loops: start, step, induction variable. #23208
+484
−313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731860761
branch
4 times, most recently
from
aa19555 to
e0b7e4c
Compare
Imported from GitHub PR #23181 Currently, we annotate while loops with a known trip count accordingly. This PR adds the start, step and induction variable so it's easy to see when a while loop is actually a for loop. For the larger context see main...jreiffers:xla:memcpy and the companion document https://docs.google.com/document/d/1E2_Jt_Dw4VbPXPVktNWhtsDEtIpN-kurCMGGyvMV4JA/edit?tab=t.0. Copybara import of the project: -- a5f8f4e by Johannes Reifferscheid <[email protected]>: Annotate loops: start, step, induction variable. Currently, we annotate while loops with a known trip count accordingly. This PR adds the start, step and induction variable so it's easy to see when a while loop is actually a for loop. For the larger context see main...jreiffers:xla:memcpy and the companion document https://docs.google.com/document/d/1E2_Jt_Dw4VbPXPVktNWhtsDEtIpN-kurCMGGyvMV4JA/edit?tab=t.0. Merging this change closes #23181 FUTURE_COPYBARA_INTEGRATE_REVIEW=#23181 from jreiffers:while-annotator a5f8f4e PiperOrigin-RevId: 731860761
copybara-service
bot
force-pushed
the
test_731860761
branch
from
e0b7e4c to
5a2abfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #23181: Annotate loops: start, step, induction variable.
Imported from GitHub PR #23181
Currently, we annotate while loops with a known trip count accordingly. This PR adds the start, step and induction variable so it's easy to see when a while loop is actually a for loop.
For the larger context see
main...jreiffers:xla:memcpy and the companion document
https://docs.google.com/document/d/1E2_Jt_Dw4VbPXPVktNWhtsDEtIpN-kurCMGGyvMV4JA/edit?tab=t.0.
Copybara import of the project:
--
a5f8f4e by Johannes Reifferscheid [email protected]:
Annotate loops: start, step, induction variable.
Currently, we annotate while loops with a known trip count accordingly.
This PR adds the start, step and induction variable so it's easy to see
when a while loop is actually a for loop.
For the larger context see
main...jreiffers:xla:memcpy and
the companion document
https://docs.google.com/document/d/1E2_Jt_Dw4VbPXPVktNWhtsDEtIpN-kurCMGGyvMV4JA/edit?tab=t.0.
Merging this change closes #23181
FUTURE_COPYBARA_INTEGRATE_REVIEW=#23181 from jreiffers:while-annotator a5f8f4e