[xla] Literal: cache buffer pointer to avoid branches on a hot path #23216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731892751
branch
2 times, most recently
from
881e973 to
5f5bbb4
Compare
``` name old cpu/op new cpu/op delta BM_UnaryOp/64/process_time 257µs ± 9% 251µs ±10% -2.09% (p=0.015 n=40+39) BM_UnaryOp/128/process_time 573µs ±12% 560µs ±11% -2.28% (p=0.025 n=40+40) BM_UnaryOp/512/process_time 6.22ms ± 9% 6.15ms ± 9% ~ (p=0.244 n=40+40) BM_UnaryOp/1024/process_time 26.0ms ± 3% 24.9ms ±11% -4.16% (p=0.000 n=31+40) BM_BinaryOp/64/process_time 266µs ±11% 258µs ± 9% -2.79% (p=0.003 n=40+39) BM_BinaryOp/128/process_time 551µs ± 6% 532µs ± 8% -3.47% (p=0.000 n=38+36) BM_BinaryOp/512/process_time 6.00ms ± 8% 5.70ms ±12% -5.05% (p=0.000 n=38+39) BM_BinaryOp/1024/process_time 23.4ms ± 6% 21.9ms ± 8% -6.36% (p=0.000 n=31+40) name old time/op new time/op delta BM_UnaryOp/64/process_time 58.9µs ±12% 57.6µs ±11% -2.31% (p=0.023 n=39+39) BM_UnaryOp/128/process_time 96.9µs ±15% 95.8µs ±19% ~ (p=0.575 n=40+40) BM_UnaryOp/512/process_time 722µs ±13% 717µs ± 9% ~ (p=0.409 n=40+39) BM_UnaryOp/1024/process_time 3.23ms ±11% 3.18ms ±19% ~ (p=0.539 n=32+40) BM_BinaryOp/64/process_time 62.7µs ±11% 60.8µs ± 9% -3.00% (p=0.004 n=39+38) BM_BinaryOp/128/process_time 109µs ±17% 105µs ±20% -3.58% (p=0.002 n=40+39) BM_BinaryOp/512/process_time 894µs ±20% 854µs ±19% -4.46% (p=0.003 n=37+38) BM_BinaryOp/1024/process_time 3.87ms ±22% 3.72ms ±18% -3.90% (p=0.042 n=40+39) ``` Benchmark numbers taken without benchmark changes in this CL. PiperOrigin-RevId: 732222763
copybara-service
bot
force-pushed
the
test_731892751
branch
from
5f5bbb4 to
f3a073e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla] Literal: cache buffer pointer to avoid branches on a hot path
Benchmark numbers taken without benchmark changes in this CL.