[xla:hlo] Templetize HloEvaluator on a hot path to remove std::function overheads #23217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731932324
branch
3 times, most recently
from
4d5b131 to
2d28b16
Compare
…on overheads ``` name old cpu/op new cpu/op delta BM_UnaryOp/64/process_time 244µs ±11% 230µs ±10% -5.76% (p=0.000 n=40+40) BM_UnaryOp/128/process_time 538µs ±13% 491µs ±11% -8.84% (p=0.000 n=40+40) BM_UnaryOp/512/process_time 5.93ms ± 6% 5.08ms ± 9% -14.33% (p=0.000 n=39+40) BM_UnaryOp/1024/process_time 24.6ms ± 6% 19.4ms ± 9% -21.21% (p=0.000 n=32+40) BM_BinaryOp/64/process_time 236µs ±10% 233µs ±12% ~ (p=0.187 n=40+40) BM_BinaryOp/128/process_time 487µs ±11% 457µs ±11% -6.31% (p=0.000 n=39+38) BM_BinaryOp/512/process_time 5.28ms ± 6% 4.66ms ± 9% -11.65% (p=0.000 n=38+40) BM_BinaryOp/1024/process_time 21.4ms ± 9% 18.3ms ± 8% -14.32% (p=0.000 n=38+40) name old time/op new time/op delta BM_UnaryOp/64/process_time 54.7µs ±15% 52.9µs ±12% ~ (p=0.077 n=40+40) BM_UnaryOp/128/process_time 83.8µs ±15% 81.8µs ±16% ~ (p=0.165 n=40+40) BM_UnaryOp/512/process_time 584µs ± 7% 516µs ±11% -11.60% (p=0.000 n=39+40) BM_UnaryOp/1024/process_time 2.41ms ± 8% 1.93ms ±12% -19.63% (p=0.000 n=36+40) BM_BinaryOp/64/process_time 52.7µs ±13% 53.3µs ±14% ~ (p=0.198 n=39+40) BM_BinaryOp/128/process_time 77.9µs ±17% 77.7µs ±15% ~ (p=0.874 n=39+39) BM_BinaryOp/512/process_time 524µs ± 9% 473µs ±12% -9.73% (p=0.000 n=40+40) BM_BinaryOp/1024/process_time 2.14ms ±15% 1.84ms ±13% -14.03% (p=0.000 n=39+40) ``` PiperOrigin-RevId: 732228284
copybara-service
bot
force-pushed
the
test_731932324
branch
from
2d28b16 to
c4429a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla:hlo] Templetize HloEvaluator on a hot path to remove std::function overheads