Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use int64_t rather than uint64_t for execution stream id #23257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Use int64_t rather than uint64_t for execution stream id #23257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xla/python/ifrt/executable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ struct ExecuteOptions {
// Execution stream ID identifies the series of executions that must be
// executed in program order. Executions with different execution stream IDs
// may be executed in any order and concurrently.
uint64_t execution_stream_id = 0;
int64_t execution_stream_id = 0;

// Custom execution options specific to the runtime. The user and the runtime
// are responsible for ensuring version compatibility.
Expand Down
2 changes: 1 addition & 1 deletion xla/python/ifrt/execute_options.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ message ExecuteOptionsProto {
int32 launch_id = 3;
repeated int32 non_donatable_input_indices = 7;
bool fill_status = 9;
uint64 execution_stream_id = 11;
int64 execution_stream_id = 11;
AttributeMapProto custom_options = 10;

reserved 1, 4 to 6, 8;
Expand Down
Loading