Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add leader node names to v1beta2.nodepool #2297

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

tnsimon
Copy link
Contributor

@tnsimon tnsimon commented Feb 4, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Store node name with leader for yurthub.

Which issue(s) this PR fixes:

Fixes #2295

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

@tnsimon tnsimon requested a review from a team as a code owner February 4, 2025 01:31
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.70%. Comparing base (0e6c0d4) to head (4589beb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nager/controller/hubleader/hubleader_controller.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2297   +/-   ##
=======================================
  Coverage   45.70%   45.70%           
=======================================
  Files         408      408           
  Lines       27146    27151    +5     
=======================================
+ Hits        12407    12410    +3     
- Misses      13516    13517    +1     
- Partials     1223     1224    +1     
Flag Coverage Δ
unittests 45.70% <86.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 4, 2025

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Feb 4, 2025
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit ffb736a into openyurtio:master Feb 4, 2025
14 checks passed
@tnsimon tnsimon deleted the add-leader-node-names branch February 4, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Store node name in v1beta2.Nodepool spec
2 participants