-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve config and start process of yurthub component #2303
Conversation
@zyjhtangtang @YTGhost PTAL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2303 +/- ##
==========================================
- Coverage 45.51% 45.40% -0.11%
==========================================
Files 408 407 -1
Lines 27049 26995 -54
==========================================
- Hits 12310 12258 -52
+ Misses 13522 13516 -6
- Partials 1217 1221 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
90c9963
to
42cdf9c
Compare
still have problem when setup openyurt cluster with kind in e2e-test |
Signed-off-by: rambohe-ch <[email protected]>
42cdf9c
to
69a4b1c
Compare
|
@YTGhost e2e errors have been fixed. please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
cmd/yurthub/app/config/config.go
andcmd/yurthub/app/start.go
, initialize instance according to working mode. the code is improved as following:then remove working mode if condition except instance initialization, so it is easy to understand the features for each working mode.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note