add more columns to arcstat #16509
Merged
add more columns to arcstat #16509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotin
reviewed
Sep 5, 2024
There was a problem hiding this comment.
I have no objections for this, but I was thinking that we should add much more of the ARC parameters there. At very least for completeness there should be also numbers for anon and uncached states. And then it would be good to see data/metadata distribution, which ARC collects for each state. And then may be evictable memory stats, etc.
Please see the current arc_summary output as an example of what can be reported. I think arcstat should be able to report all the same numbers to allow their analysis in dynamics.
|
I've added more columns as suggested. Let me know if anything is missing. ^^ |
tkittich
changed the title
amotin
approved these changes
Sep 6, 2024
|
I've add more columns. Everything from ARC structural breakdown, ARC types breakdown, ARC states breakdown in arc_summary should be in here. |
amotin
approved these changes
Sep 9, 2024
|
And please squash the commits. |
Thank you for the review. I've added target sizes, changed column names to fit 5 chars, and squash the commits. ^^ |
tkittich
force-pushed
the
master
branch
2 times, most recently
from
6e8c31c to
bed3022
Compare
|
I've added target size of ARC data, ARC metadata, MFU, MRU. ^^ |
amotin
approved these changes
Sep 10, 2024
|
Anon_size is definitely the one I've wanted many times |
|
I've shorten new column names. Also, I've modified to display decimal places when number is < 10. This will be helpful when interval is large. The values when divided by large interval would become very small. The old behavior would round down small numbers to 0. |
|
Fractional bytes or operations may weird is they are not percents or per-second. ;) |
The latest commit has a fix that will not show decimal places when interval is 1 and value is integer. It'll also show decimal digits when value > 10 if there's enough space.^^ |
Signed-off-by: Theera K. <[email protected]> arcstat: add structural, types, states breakdown add ARC structural breakdown, ARC types breakdown, ARC states breakdown similar to arc_summary Signed-off-by: Theera K. <[email protected]> rename column names to fit 5 chars Signed-off-by: Theera K. <[email protected]> rename column names to fit 5 chars Signed-off-by: Theera K. <[email protected]> add data target, metadata target Signed-off-by: Theera K. <[email protected]> add data target, metadata target Signed-off-by: Theera K. <[email protected]> fix abd typo Signed-off-by: Theera K. <[email protected]> fix abd typo Signed-off-by: Theera K. <[email protected]> make column name a bit shorter Signed-off-by: Theera K. <[email protected]> make column name a bit shorter Signed-off-by: Theera K. <[email protected]> fix structural typo Signed-off-by: Theera K. <[email protected]> Delete cmd/arc_summary.py incorrect file extension Signed-off-by: Theera K. <[email protected]> fix structural typo Signed-off-by: Theera K. <[email protected]> arcstat: add structural, types, states breakdown add ARC structural breakdown, ARC types breakdown, ARC states breakdown similar to arc_summary Signed-off-by: Theera K. <[email protected]> Update arcstat: add Anonymous, MFU, MRU, Uncached Signed-off-by: Theera K. <[email protected]> Update arcstat: add Anonymous, MFU, MRU, Uncached Signed-off-by: Theera K. <[email protected]> Update arcstat: add Anonymous, MFU, MRU, Uncached Signed-off-by: Theera K. <[email protected]> Update arcstat.1 : add mfusz, mrusz, l2wbytes Signed-off-by: Theera K. <[email protected]> Update arcstat: add mfusz, mrusz, l2wbytes mfusz: MFU size mrusz: MRU size l2wbytes: Bytes write per second to the L2ARC Signed-off-by: Theera K. <[email protected]> remove extra spaces Signed-off-by: Theera K. <[email protected]> arcstat: add target size of data, meta, MFU, MRU arcstat: add target size of ARC data, ARC metadata, MFU, MRU Signed-off-by: Theera K. <[email protected]> arcstat: add target size of data, meta, MFU, MRU arcstat: add target size of ARC data, ARC metadata, MFU, MRU Signed-off-by: Theera K. <[email protected]> shorten new column names; show decimal when < 10 Signed-off-by: Theera K. <[email protected]> prettynum: add special case when interval is 1 when interval is 1 only show decimal when value is < 1 Signed-off-by: Theera K. <[email protected]> fix scale == 100 & change prettynum() Signed-off-by: Theera K. <[email protected]> fix prettynum rounding Signed-off-by: Theera K. <[email protected]>
behlendorf
approved these changes
Sep 18, 2024
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Nov 11, 2024
Add ARC structural breakdown, ARC types breakdown, ARC states breakdown similar to arc_summary. Additional cleanups included. Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Theera K. <[email protected]> Closes openzfs#16509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
add more columns to arcstat. Everything from ARC structural breakdown, ARC types breakdown, ARC states breakdown in arc_summary should be in here. Also, I've modified to display decimal places if there's enough space. This will be helpful when interval is large. The values when divided by large interval would become very small. The old behavior would round down small numbers to 0.
Description
How Has This Been Tested?
Tested locally.
Types of changes
Checklist:
Signed-off-by.