Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: unicode: remove unused uconv.c (#13224) #16702

Merged
merged 1 commit into from
Nov 1, 2024
Merged

module: unicode: remove unused uconv.c (#13224) #16702

merged 1 commit into from
Nov 1, 2024

Conversation

nabijaczleweli
Copy link
Contributor

Motivation and Context

Extracted from #13224

Description

rm module/unicode/uconv.c

How Has This Been Tested?

Builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. — none apply
  • I have run the ZFS Test Suite with this change applied. — CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli
module: unicode: remove unused uconv.c
1c1cec3 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli nabijaczleweli mentioned this pull request Oct 30, 2024
Closed
13 tasks
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Oct 30, 2024
@behlendorf behlendorf merged commit 1c7d4b4 into openzfs:master Nov 1, 2024
20 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
@nabijaczleweli @lundman
module: unicode: remove unused uconv.c
0ad1028 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#16702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @behlendorf @amotin