Remount datasets on soft-reboot #16845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kotauskas <[email protected]>
behlendorf
approved these changes
Dec 13, 2024
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Dec 16, 2024
The one-shot zfs-mount.service is incorrectly deemed active by Systemd after a systemctl soft-reboot. As such, soft-rebooting prevents zfs mount -a from being ran automatically. This commit makes it so that zfs-mount.service is marked as being undone by the time umount.target is reached, so that zfs.target then pulls it in again and gets it restarted after a soft reboot. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: kotauskas <[email protected]> Closes openzfs#16845
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Jan 26, 2025
The one-shot zfs-mount.service is incorrectly deemed active by Systemd after a systemctl soft-reboot. As such, soft-rebooting prevents zfs mount -a from being ran automatically. This commit makes it so that zfs-mount.service is marked as being undone by the time umount.target is reached, so that zfs.target then pulls it in again and gets it restarted after a soft reboot. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: kotauskas <[email protected]> Closes openzfs#16845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, the one-shot
zfs-mount.serviceis incorrectly deemed active by Systemd after asystemctl soft-reboot. As such, soft-rebooting preventszfs mount -afrom being ran automatically.Description
This PR makes it so that
zfs-mount.serviceis marked as being undone by the timeumount.targetis reached, so thatzfs.targetthen pulls it in again and gets it restarted after a soft reboot.How Has This Been Tested?
I put those changes into a drop-in and it made
zfs mount -arun automatically after soft reboots as expected.Types of changes
Checklist:
Signed-off-by.