ZTS: functional/mount scripts are not removing /var/tmp/testdir.X directories

[tsoome]

cleanup.ksh is assuming we have TESTDIRS set [it is not].

Motivation and Context

Clean up left over files after zfstests.

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• [ x] My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• [ x] I have run the ZFS Test Suite with this change applied.
• [x ] All commit messages are properly formatted and contain Signed-off-by.

[amotin]

@tsoome Please fix too long line in commit message.

[tonyhutter]

Yea, I don't see TESTDIRS defined anywhere. I wonder if we can remove these as well?

~/zfs $ fgrep -RIn TESTDIRS 
tests/zfs-tests/tests/functional/mount/cleanup.ksh:36:for dir in $TESTDIRS; do
tests/zfs-tests/tests/functional/pam/cleanup.ksh:30:log_must rm -rf "$runstatedir" $TESTDIRS

[behlendorf]

I don't see TESTDIRS defined anywhere. I wonder if we can remove these as well?

Indeed. We should remove it from tests/zfs-tests/tests/functional/pam/cleanup.ksh as well. At least in this case it's harmless since it will expand to nothing. Still, something we should cleanup.

[tsoome]

I don't see TESTDIRS defined anywhere. I wonder if we can remove these as well?

Indeed. We should remove it from tests/zfs-tests/tests/functional/pam/cleanup.ksh as well. At least in this case it's harmless since it will expand to nothing. Still, something we should cleanup.

I'd leave that for separate update, so it is easier for me to keep track with illumos changes.