Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dedup_legacy_create test in common.run #16926

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

rrevans
Copy link
Contributor

@rrevans rrevans commented Jan 4, 2025

Motivation and Context

common.run lists tests/functional/dedup/dedup_legacy_create twice for unknown reasons:

[tests/functional/dedup]
tests = ['dedup_legacy_create', 'dedup_fdt_create', 'dedup_fdt_import',
'dedup_legacy_create', 'dedup_legacy_import', 'dedup_legacy_fdt_upgrade',
'dedup_legacy_fdt_mixed', 'dedup_quota']

This is detected by my experimental tooling that runs ZTS in parallel distributed to local VMs. It reports a warning if it observes the same test outcome twice. Turns out in this case the test is in the runfile twice.

I'm not 100% sure it should appear only once, but it seems odd that it's there twice. @allanjude is this a typo from c7ada64?

Description

Remove the duplicate test

How Has This Been Tested?

Ran the common.run suite

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure looks like a typo. There's no need to run this test multiple times.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jan 4, 2025
@behlendorf behlendorf merged commit 3a445f2 into openzfs:master Jan 6, 2025
24 of 25 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jan 6, 2025
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Robert Evans <[email protected]>
Closes openzfs#16926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants