Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: cleanup $KERNEL_CC checks #16997

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build: cleanup $KERNEL_CC checks #16997

wants to merge 2 commits into from

Conversation

intelfx
Copy link

@intelfx intelfx commented Jan 28, 2025

Motivation and Context

  • general cleanup of build system, improves correctness of status messages

Description

  • config: cleanup KERNEL_CC checks, fix broken status output
  • config: add and use KERNEL_CC check for -Wno-format-zero-length

How Has This Been Tested?

  • build-tested on x86_64

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@intelfx
config: cleanup KERNEL_CC checks, fix broken status output
08449f9 
If $KERNEL_CC was not defined, configure status output would print an
empty string where the kernel compiler should have been. Fix this and
simplify the code generally.

Signed-off-by: Ivan Shapovalov <[email protected]>
@intelfx
config: add and use KERNEL_CC check for -Wno-format-zero-length
cc75978 
Signed-off-by: Ivan Shapovalov <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intelfx @amotin