cmd/zfs: support creating parents with canmount=no
#17000
Draft
+84
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Shapovalov <[email protected]>
Signed-off-by: Ivan Shapovalov <[email protected]>
This will be used to support creating non-mountable ancestors in zfs(8). Signed-off-by: Ivan Shapovalov <[email protected]>
Teach `zfs {create,clone,rename}` to accept a doubled `-p` flag (`-pp`)
to create non-existing ancestor datasets with `canmount=off`.
Signed-off-by: Ivan Shapovalov <[email protected]>
github-actions
bot
added
the
Status: Work in Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Sometimes (depending on the dataset organization practice chosen by the admin),
a pool will make heavy use of empty datasets with
canmount=nothat are usedstrictly to group other contained datasets and/or inherit properties such as
mountpoint. This organization practice is referenced in zfsprops(7).Under these conditions, using
zfs create -p(and other commands with-p)is very inconvenient because the parent datasets will be created with the
default value of
canmount(which is non-inheritable).Description
This branch adds an optional mode to
zfs create,zfs renameandzfs clonesubcommands that requests ZFS to create parent datasets with
canmount=no.For now, this mode is invoked via a double
-poption (e.g.,zfs create -pp)because I don't have a better idea. Suggestions welcome.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.